Added truncation logic for text type message in rooms #2110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ajbura Hey can you review this please |
ajbura
requested changes
Dec 28, 2024
Comment on lines
93
to
106
| const { shouldTruncate, finalContent, finalCustomContent } = useMemo(() => { | ||
| const contentStr = trimmedBody || ''; | ||
| const customContentStr = typeof customBody === 'string' ? trimReplyFromBody(customBody) : ''; | ||
| const needTruncate = contentStr.length > 750 || customContentStr.length > 750; | ||
| return { | ||
| contentStr, | ||
| customContentStr, | ||
| shouldTruncate: needTruncate, | ||
| finalContent: isExpanded ? contentStr : truncateText(contentStr, CHARACTER_LIMIT), | ||
| finalCustomContent: isExpanded | ||
| ? customContentStr | ||
| : truncateText(customContentStr, CHARACTER_LIMIT), | ||
| }; | ||
| }, [trimmedBody, customBody, isExpanded]); |
There was a problem hiding this comment.
I have following concern:
- using the memoization is not really needed here as we are not doing any time consuming computation and conditional logic can be used directly while rendering.
contentStrandcustomContentStrare just the copy ofbodyandcustomBodywithout any changes.trimReplyFromBodyis used oncustomBodyand it is only meant to be used on plainbody.truncateTextcut the customHTML body right after 750 chars which can breaks the customHTML tags entirely.
There was a problem hiding this comment.
Done . Now truncation of customHTML tags is done correctly.
| {shouldTruncate && ( | ||
| <button | ||
| aria-expanded={isExpanded} | ||
| className="show-more" |
There was a problem hiding this comment.
Please use the components from design system(Folds) and CSS-in-JS instead of global css.
ajbura
requested changes
Dec 28, 2024
| @@ -27,6 +27,9 @@ import { FALLBACK_MIMETYPE, getBlobSafeMimeType } from '../../utils/mimeTypes'; | |||
| import { parseGeoUri, scaleYDimension } from '../../utils/common'; | |||
| import { Attachment, AttachmentBox, AttachmentContent, AttachmentHeader } from './attachment'; | |||
| import { FileHeader } from './FileHeader'; | |||
| import { Button } from 'folds'; | |||
There was a problem hiding this comment.
Pardon me for this silly mistake.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added truncation logic for chat room text messages. Previously, if anyone sent a large message, it would occupy the entire screen.
Fixes #2094
Before:
Screen.Recording.2024-12-23.at.11.23.54.AM.1.mov
After:
Screen.Recording.2024-12-23.at.11.22.02.AM.mov
Type of change
Checklist: