Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Large message folding #2094

Open
gytic opened this issue Dec 16, 2024 · 0 comments · May be fixed by #2110
Open

Large message folding #2094

gytic opened this issue Dec 16, 2024 · 0 comments · May be fixed by #2110

Comments

@gytic
Copy link

gytic commented Dec 16, 2024

Describe the problem

In the current version of cinny, a long message can take up the whole screen, which can make it hard to catch up with what happend.

large_message_filling_whole_screen

Describe the solution you'd like

I think it would be reasonable to crop large text messages.

This means a preview (the start of the message) will always be shown, but the rest of the message will be hidden at some point. The full message can be shown through a "show all" button at the end of the message.
shortend_message

Alternatives considered

none

Additional context

It would be up to debate how to detect a "long message". Two options that immediately come to my mind:

  • based on occupied screen space
  • based on character count

I think the character count would be easier to implement, because there would be a clear limit where to make the split. However calculating the max size of a message based on screen size would be more user friendly, as a message will generally take up more space on a smaller screen than on a larger one, which should be taken into account when cropping a message.

@Vishawdeep-Singh Vishawdeep-Singh linked a pull request Dec 23, 2024 that will close this issue
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant