Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[签名出错]feat: Remove a tip when open a blocked group(Tim 3.5.1) #774

Closed
wants to merge 6 commits into from

Conversation

MoonLeeeaf
Copy link
Contributor

@MoonLeeeaf MoonLeeeaf commented Jan 26, 2024

移除“修改消息设置,实时接收或收入群助手”

备注

实在没有IDE能调试,还请各位大佬帮我测试下

第一次提交PR,有什么问题欢迎各位大佬指点

该方法针对 Tim 3.5.1

针对内容如下图

Screenshot_20240126_145902
Screenshot_20240126_145853

关联的 issue

#667

@MoonLeeeaf MoonLeeeaf changed the title feat: Remove a tip when open a blocked group feat: Remove a tip when open a blocked group(Tim 3.5.1) Jan 26, 2024
Copy link
Owner

@cinit cinit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

建议修改一下包名,撤销 gradlew mode 的改动,另外 commit 建议 GPG 签名

gradlew Outdated Show resolved Hide resolved
@MoonLeeeaf
Copy link
Contributor Author

MoonLeeeaf commented Jan 26, 2024

我明明配置好了GPG啊?What happened?>.<
Screenshot_20240127_000629

@MoonLeeeaf MoonLeeeaf marked this pull request as ready for review January 26, 2024 16:05
Copy link
Contributor Author

@MoonLeeeaf MoonLeeeaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已根据要求进行修改(修改后的commit),感谢大佬指点
我发现我的GPG签名用了Github的只读邮箱居然还是unverified,现在我不知道要怎么重新签名了:-(

gradlew Outdated Show resolved Hide resolved
@cinit
Copy link
Owner

cinit commented Jan 27, 2024

  1. 你的 GPG 公钥要上传到 GitHub
  2. 你 commit 的邮箱要和你 GPG id 邮箱一致

@MoonLeeeaf
Copy link
Contributor Author

MoonLeeeaf commented Jan 27, 2024

本次Pull Request出的问题有点多,改天我重新来走一遍流程,实在抱歉

MoonLeeeaf and others added 4 commits January 27, 2024 13:49
Signed-off-by: MoonLeeeaf <EMAIL>
Signed-off-by: MoonLeeeaf <[email protected]>
Signed-off-by: MoonLeeeaf <[email protected]>
Signed-off-by: MoonLeeeaf <[email protected]>
@MoonLeeeaf MoonLeeeaf closed this Jan 27, 2024
@MoonLeeeaf MoonLeeeaf changed the title feat: Remove a tip when open a blocked group(Tim 3.5.1) [签名出错]feat: Remove a tip when open a blocked group(Tim 3.5.1) Jan 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants