Improve handling of invalid workdir creation #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LegenJCdary
force-pushed
the
non_existing_workdir
branch
from
0430744 to
fba33aa
Compare
cinek810
requested changes
Mar 24, 2022
| seq_path = os.path.join(date_dir, f"{conf['file_naming']['sequence_prefix']}" | ||
| f"{new_sequence:04d}") | ||
| except Exception as exc: | ||
| logger.critical("Failed to list work dir due to: %s", exc) |
There was a problem hiding this comment.
We should add tests for those criticals. Maybe a second configuration file with a different workdir run from another .sh ?
| except Exception as e: | ||
| logger.critical("Failed to create work dir:%s error was:%s", seq_path, e, file=sys.stderr) | ||
| except Exception as exc: | ||
| logger.critical("Failed to create work dir: %s due to: %s", seq_path, exc) |
LegenJCdary
force-pushed
the
non_existing_workdir
branch
14 times, most recently
from
9110502 to
c72918b
Compare
LegenJCdary
force-pushed
the
non_existing_workdir
branch
12 times, most recently
from
311cce3 to
edb3071
Compare
LegenJCdary
force-pushed
the
non_existing_workdir
branch
19 times, most recently
from
353f89e to
76cc173
Compare
LegenJCdary
force-pushed
the
non_existing_workdir
branch
2 times, most recently
from
4caf999 to
42ebf48
Compare
cinek810
force-pushed
the
main
branch
5 times, most recently
from
4cdc87c to
c1f7847
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixing issue #45