Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry workdir creation (race condition fix) #206

Merged
merged 3 commits into from
Dec 12, 2024

Conversation

LegenJCdary
Copy link
Collaborator

No description provided.

@LegenJCdary LegenJCdary marked this pull request as draft October 24, 2024 13:12
@LegenJCdary LegenJCdary marked this pull request as ready for review November 4, 2024 23:18
@LegenJCdary LegenJCdary marked this pull request as draft November 4, 2024 23:18
@LegenJCdary LegenJCdary requested a review from cinek810 November 4, 2024 23:18
@LegenJCdary
Copy link
Collaborator Author

@cinek810 let me know how to handle counter, my propositions are in an in-code comment.

@cinek810
Copy link
Owner

Just hardcode it inside create_workdir

@LegenJCdary LegenJCdary marked this pull request as ready for review November 28, 2024 11:59
Copy link
Owner

@cinek810 cinek810 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good at a glance

@cinek810 cinek810 merged commit 0629807 into cinek810:main Dec 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants