Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repository factory is added. #206

Merged
merged 1 commit into from
Sep 7, 2024
Merged

Repository factory is added. #206

merged 1 commit into from
Sep 7, 2024

Conversation

cinar
Copy link
Owner

@cinar cinar commented Sep 7, 2024

Describe Request

Repository factory is added.

Change Type

New feature.

@cinar cinar merged commit 17ec52a into master Sep 7, 2024
5 checks passed
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 20.00000% with 36 lines in your changes missing coverage. Please review.

Project coverage is 93.20%. Comparing base (30dd0d0) to head (ba8b8fe).

Files with missing lines Patch % Lines
cmd/indicator-sync/main.go 0.00% 22 Missing ⚠️
cmd/indicator-backtest/main.go 0.00% 10 Missing ⚠️
asset/repository_factory.go 69.23% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #206      +/-   ##
==========================================
- Coverage   93.60%   93.20%   -0.41%     
==========================================
  Files         154      155       +1     
  Lines        4036     4063      +27     
==========================================
+ Hits         3778     3787       +9     
- Misses        210      227      +17     
- Partials       48       49       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cinar cinar deleted the repository-factory branch September 7, 2024 02:59
@github-actions github-actions bot locked and limited conversation to collaborators Sep 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants