Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strategies return nonnormalized actions #193

Merged
merged 6 commits into from
Sep 7, 2024
Merged

Strategies return nonnormalized actions #193

merged 6 commits into from
Sep 7, 2024

Conversation

cinar
Copy link
Owner

@cinar cinar commented Jul 21, 2024

Describe Request

Strategies return nonnormalized actions.

Fixed #192

Change Type

New feature.

@codecov-commenter
Copy link

codecov-commenter commented Jul 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.27%. Comparing base (cba1c86) to head (b7dd7c3).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #193      +/-   ##
==========================================
- Coverage   93.30%   93.27%   -0.03%     
==========================================
  Files         155      155              
  Lines        4063     4047      -16     
==========================================
- Hits         3791     3775      -16     
  Misses        224      224              
  Partials       48       48              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@heiningair
Copy link

works as expected. it produces non-normalized actions now!

In my test I combined multiple strategies via AndStrategy

@cinar cinar merged commit 7076260 into master Sep 7, 2024
5 checks passed
@cinar cinar deleted the issue-192 branch September 7, 2024 15:55
@github-actions github-actions bot locked and limited conversation to collaborators Sep 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Strategies should return nonnormalized recommendations
3 participants