Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update */README.md with latest code #171

Closed
wants to merge 8 commits into from
Closed

Update */README.md with latest code #171

wants to merge 8 commits into from

Conversation

sunglim
Copy link
Contributor

@sunglim sunglim commented Jul 10, 2024

This commit updates */README.md with a result of sh pre-commit.sh

Describe Request

As the doc is slightly outdated, update docs with the latest code. It's a result of sh pre-commit.sh.

Fixed # N/A

Change Type

Documentation

This commit updates */README.md with a result of `sh pre-commit.sh`
@sunglim
Copy link
Contributor Author

sunglim commented Jul 10, 2024

I'm actually thinking there should be a github workflow to periodically check docs, and create PR.
I used Fixed # N/A. because this PR is a trivial. I'd like to follow your rule. let me know if you need an issue#.

@codecov-commenter
Copy link

codecov-commenter commented Jul 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.48%. Comparing base (7168efc) to head (c1412ce).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #171   +/-   ##
=======================================
  Coverage   93.48%   93.48%           
=======================================
  Files         151      151           
  Lines        3932     3932           
=======================================
  Hits         3676     3676           
  Misses        209      209           
  Partials       47       47           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cinar
Copy link
Owner

cinar commented Jul 10, 2024

I agree with you. I have been thinking making this part of the workflow.

@sunglim
Copy link
Contributor Author

sunglim commented Jul 10, 2024

I agree with you. I have been thinking making this part of the workflow.

Thanks for the comment. I created a ticket for it. #172

If allowed, I'd like to take the issue.

@sunglim
Copy link
Contributor Author

sunglim commented Jul 10, 2024

Hm.. sorry the commit list is so dirty. I'll create PR again.
image

@sunglim sunglim closed this Jul 10, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jul 10, 2024
@sunglim sunglim deleted the docupdate branch July 10, 2024 16:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants