cleanup: validation - removed Success

cime · Mar 1, 2021 · fb4aff4 · fb4aff4
1 parent f1f490e
commit fb4aff4
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 6 deletions.
diff --git a/CoreSharp.Validation.Tests/Models/AsyncParent.cs b/CoreSharp.Validation.Tests/Models/AsyncParent.cs
@@ -84,11 +84,11 @@ public override Task BeforeValidationAsync(TModel root, ValidationContext contex
             return Task.CompletedTask;
         }
 
-        public override async IAsyncEnumerable<ValidationFailure> ValidateAsync(TChild child, ValidationContext context)
+        public override IAsyncEnumerable<ValidationFailure> ValidateAsync(TChild child, ValidationContext context)
         {
             ValidateModels.Add(new Tuple<TChild, IAsyncDomainValidator>(child, this));
 
-            yield break;
+            return null;
         }
 
         public override Task<bool> CanValidateAsync(TChild child, ValidationContext context)

diff --git a/CoreSharp.Validation.Tests/Models/TestModel.cs b/CoreSharp.Validation.Tests/Models/TestModel.cs
@@ -57,10 +57,11 @@ public override Task BeforeValidationAsync(TestModel root, ValidationContext con
             return Task.CompletedTask;
         }
 
-        public override async IAsyncEnumerable<ValidationFailure> ValidateAsync(TestModel child, ValidationContext context)
+        public override IAsyncEnumerable<ValidationFailure> ValidateAsync(TestModel child, ValidationContext context)
         {
             ValidateCount++;
-            yield break;
+
+            return null;
         }
 
         public override Task<bool> CanValidateAsync(TestModel child, ValidationContext context)

diff --git a/CoreSharp.Validation/AbstractAsyncDomainValidator.cs b/CoreSharp.Validation/AbstractAsyncDomainValidator.cs
@@ -52,7 +52,5 @@ protected ValidationFailure Failure(string errorMessage, ValidationContext conte
         {
             return DomainValidationContext.CreateValidationFailure(errorMessage, context);
         }
-
-        protected ValidationFailure Success => null;
     }
 }
-Original file line number
+Diff line change
@@ Expand Up @@
             {
                 return DomainValidationContext.CreateValidationFailure(errorMessage, context);
             }
-            protected ValidationFailure Success => null;
         }
     }