Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: setup fuzzer #4

Merged
merged 1 commit into from
Jan 19, 2024
Merged

chore: setup fuzzer #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions fuzz/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
target
corpus
artifacts
coverage
25 changes: 25 additions & 0 deletions fuzz/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
[package]
name = "nodejs-semver-fuzz"
version = "0.0.0"
publish = false
edition = "2021"

[package.metadata]
cargo-fuzz = true

[dependencies]
libfuzzer-sys = "0.4"
nodejs-semver = { path = "../" }

# Prevent this from interfering with workspaces
[workspace]
members = ["."]

[profile.release]
debug = 1

[[bin]]
name = "semver"
path = "fuzz_targets/semver.rs"
test = false
doc = false
5 changes: 5 additions & 0 deletions fuzz/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
# Development

```sh
cargo +nightly fuzz run semver -- -only_ascii=1 -max_total_time=60 -max_len=30
```
12 changes: 12 additions & 0 deletions fuzz/fuzz_targets/semver.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
#![no_main]

use nodejs_semver::{Version, Range};

libfuzzer_sys::fuzz_target!(|data: &[u8]| {
if let Ok(s) = std::str::from_utf8(data) {
if s.chars().all(|s| !s.is_control()) {
let _ = Version::parse(&s);
let _ = Range::parse(&s);
}
}
});
251 changes: 122 additions & 129 deletions src/range.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -667,139 +667,132 @@ fn primitive(input: &str) -> IResult<&str, Option<BoundSet>, SemverParseError<&s
use Operation::*;

Parser::map(
(operation, preceded(space0, partial_version)),
|parsed| {
match parsed {
(GreaterThanEquals, partial) => {
BoundSet::at_least(Predicate::Including(partial.into()))
}
(
GreaterThan,
Partial {
major: Some(major),
minor: Some(minor),
patch: None,
..
},
) => BoundSet::at_least(Predicate::Including((major, minor + 1, 0).into())),
(
GreaterThan,
Partial {
major: Some(major),
minor: None,
patch: None,
..
},
) => BoundSet::at_least(Predicate::Including((major + 1, 0, 0).into())),
(GreaterThan, partial) => BoundSet::at_least(Predicate::Excluding(partial.into())),
(
LessThan,
Partial {
major: Some(major),
minor: Some(minor),
patch: None,
..
},
) => BoundSet::at_most(Predicate::Excluding((major, minor, 0, 0).into())),
(
LessThan,
Partial {
major,
minor,
patch,
pre_release,
build,
..
},
) => BoundSet::at_most(Predicate::Excluding(Version {
major: major.unwrap_or(0),
minor: minor.unwrap_or(0),
patch: patch.unwrap_or(0),
build,
pre_release,
})),
(
LessThanEquals,
Partial {
major,
minor: None,
patch: None,
..
},
) => BoundSet::at_most(Predicate::Including(
(major.unwrap_or(0), MAX_SAFE_INTEGER, MAX_SAFE_INTEGER).into(),
)),
(
LessThanEquals,
Partial {
major,
minor,
patch: None,
..
},
) => BoundSet::at_most(Predicate::Including(
(major.unwrap_or(0), minor.unwrap_or(0), MAX_SAFE_INTEGER).into(),
)),
(LessThanEquals, partial) => {
BoundSet::at_most(Predicate::Including(partial.into()))
}
(
Exact,
Partial {
major: Some(major),
minor: Some(minor),
patch: Some(patch),
pre_release,
..
},
) => BoundSet::exact( Version {
(operation, preceded(space0, partial_version)),
|parsed| match parsed {
(GreaterThanEquals, partial) => {
BoundSet::at_least(Predicate::Including(partial.into()))
}
(
GreaterThan,
Partial {
major: Some(major),
minor: Some(minor),
patch: None,
..
},
) => BoundSet::at_least(Predicate::Including((major, minor + 1, 0).into())),
(
GreaterThan,
Partial {
major: Some(major),
minor: None,
patch: None,
..
},
) => BoundSet::at_least(Predicate::Including((major + 1, 0, 0).into())),
(GreaterThan, partial) => BoundSet::at_least(Predicate::Excluding(partial.into())),
(
LessThan,
Partial {
major: Some(major),
minor: Some(minor),
patch: None,
..
},
) => BoundSet::at_most(Predicate::Excluding((major, minor, 0, 0).into())),
(
LessThan,
Partial {
major,
minor,
patch,
pre_release,
build,
..
},
) => BoundSet::at_most(Predicate::Excluding(Version {
major: major.unwrap_or(0),
minor: minor.unwrap_or(0),
patch: patch.unwrap_or(0),
build,
pre_release,
})),
(
LessThanEquals,
Partial {
major,
minor: None,
patch: None,
..
},
) => BoundSet::at_most(Predicate::Including(
(major.unwrap_or(0), MAX_SAFE_INTEGER, MAX_SAFE_INTEGER).into(),
)),
(
LessThanEquals,
Partial {
major,
minor,
patch: None,
..
},
) => BoundSet::at_most(Predicate::Including(
(major.unwrap_or(0), minor.unwrap_or(0), MAX_SAFE_INTEGER).into(),
)),
(LessThanEquals, partial) => BoundSet::at_most(Predicate::Including(partial.into())),
(
Exact,
Partial {
major: Some(major),
minor: Some(minor),
patch: Some(patch),
pre_release,
..
},
) => BoundSet::exact(Version {
major,
minor,
patch,
pre_release,
build: vec![],
}),
(
Exact,
Partial {
major: Some(major),
minor: Some(minor),
..
},
) => BoundSet::new(
Bound::Lower(Predicate::Including((major, minor, 0).into())),
Bound::Upper(Predicate::Excluding(Version {
major,
minor: minor + 1,
patch: 0,
pre_release: vec![Identifier::Numeric(0)],
build: vec![],
}),
(
Exact,
Partial {
major: Some(major),
minor: Some(minor),
..
},
) => BoundSet::new(
Bound::Lower(Predicate::Including(
(major, minor, 0).into(),
)),
Bound::Upper(Predicate::Excluding(Version {
major,
minor: minor + 1,
patch: 0,
pre_release: vec![Identifier::Numeric(0)],
build: vec![],
})),
),
(
Exact,
Partial {
major: Some(major),
..
},
) => BoundSet::new(
Bound::Lower(Predicate::Including(
(major, 0, 0).into(),
)),
Bound::Upper(Predicate::Excluding(Version {
major: major + 1,
minor: 0,
patch: 0,
pre_release: vec![Identifier::Numeric(0)],
build: vec![],
})),
),
_ => unreachable!("Failed to parse operation. This should not happen and should be reported as a bug, while parsing {}", input),
}
},
).context("operation range (ex: >= 1.2.3)").parse_next(input)
})),
),
(
Exact,
Partial {
major: Some(major), ..
},
) => BoundSet::new(
Bound::Lower(Predicate::Including((major, 0, 0).into())),
Bound::Upper(Predicate::Excluding(Version {
major: major + 1,
minor: 0,
patch: 0,
pre_release: vec![Identifier::Numeric(0)],
build: vec![],
})),
),
_ => None,
},
)
.context("operation range (ex: >= 1.2.3)")
.parse_next(input)
}

fn operation(input: &str) -> IResult<&str, Operation, SemverParseError<&str>> {
Expand Down Expand Up @@ -996,7 +989,7 @@ fn tilde(input: &str) -> IResult<&str, Option<BoundSet>, SemverParseError<&str>>
Bound::Lower(Predicate::Including((major, 0, 0).into())),
Bound::Upper(Predicate::Excluding((major + 1, 0, 0, 0).into())),
),
_ => unreachable!("This should not have parsed: {}", input),
_ => None,
})
.context("tilde version range (ex: ~1.2.3)")
.parse_next(input)
Expand Down