Addon to V2 #342
Merged
Addon to V2 #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
mkszepp
commented
Jan 3, 2024
•
mkszepp
commented
- Migrate Addon to V2 (embroider / ember-auto-import v2 is required)
- Switch from npm to pnpm
Closed
| "ember-truth-helpers": "^4.0.3" | ||
| }, | ||
| "devDependencies": { | ||
| "@babel/core": "^7.23.7", |
There was a problem hiding this comment.
I think you need to add the missing dependencies like ember-power-calendar-moment here to fix some of the errors
There was a problem hiding this comment.
no, this is correct so.. the addon doen't need to know which meta package is used. we can also remove the peerDependency because its not required
|
@hassanshaikh7466 published with tag |
|
Thank you for this @mkszepp. We were migrating our app to embroider and this update will really help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.