Add tox templates #2
Conversation
| @@ -0,0 +1,90 @@ | |||
| - parameter: | |||
There was a problem hiding this comment.
seems like this file is not related to this commit.
It would be better to move this file to separate commit
library/macros/stash-trigger.yaml
Outdated
|
|
||
| publishers: | ||
| - stash: | ||
| url: https://git.acronis.com |
library/scripts/jjb_compare_xml.sh
Outdated
|
|
||
| set -ex | ||
|
|
||
| # workaround for old RHELs, we need to install correct tox system-wide |
There was a problem hiding this comment.
What about comment at begin of file with name of parameters which is expected by this script.
akaRem
force-pushed
the
initial-stuff-2
branch
6 times, most recently
from
55bea84 to
c7dbd3b
Compare
This patch adds template and couple of useful macro for performing xml comparisements of JJ changes
This patch adds tox templates for running tox on generic repository
| set -ex | ||
|
|
||
| # workaround for old RHELs, we need to install correct tox system-wide | ||
| rm -rf venv |
There was a problem hiding this comment.
IMHO: it is node configuration, and it should not be part of this script.
| mv "./output/${ENV##*/}" "./output/jobs/new/${ENV##*/}" | ||
| done | ||
|
|
||
| compare_xml() { |
There was a problem hiding this comment.
it is hard to read, because function declaration execution flow.
it would be better to move function declaration in top of file or remove it, because there is only one place where function is called.
| @@ -0,0 +1,67 @@ | |||
| - job-template: | |||
There was a problem hiding this comment.
IMHO: this file is stash related, so its name or location should reflect this fact.
| tox/timeout: 10 | ||
|
|
||
| jobs: | ||
| - library/tox |
This patch adds tox templates for running tox on
generic repository