WIP: Registerable WorldFormat api #1795
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
all are now abstract
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I mainly want comments on general structure, everything else is bikesheddable. I'll go over everything again and polish it up before review.
Lots of changes here, so far I've only looked at loading worlds from the gui, haven't looked at reloading from the previous
session
Chunk,World,Dimensionare now abstract classes, the previous implementation is nowJavaChunketc.there is also a skeleton of registerable
WorldFormats. Each is asked if a directory is valid for it, if the user selects it, the format is asked to load the world.The ultimate goal would probably be to have
Chunkbe an implementation detail of java world, but that's a much larger task as it would require a rewrite of parts of the map view and scene chunk loading