Update to JUnit5, Update to J17 and J21 for tests #1736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NotStirred
changed the title
leMaik
requested changes
Jun 24, 2024
NotStirred
force-pushed
the
feature/junit5
branch
from
830c9ef to
3c63b21
Compare
|
I moved most things into the subproject closure so it should be much easier to understand. Everything now has junit tests and jacoco coverage enabled. |
|
Maybe we can keep the launcher compatible with Java 8, just in case. At least the part that checks and updates Java. |
|
hrm, in that case it may be best to specify in each project separately, as the launcher depends on |
leMaik
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I switched from google truth to assertj, as truth depends heavily on junit4. No code changes thankfully, only imports (apis we use are identical)
Only thing of note:
QuickMathTest#testAbs_1was previously incorrect (and now fails, relevant part is commented out)Probably best not to squash as the two commits are entirely separate