Add "Quit Chunky" confirmation dialog #1703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShirleyNekoDev
force-pushed
the
fix/951-add-close-confirmation
branch
from
8bae2f9 to
4b990e4
Compare
leMaik
reviewed
Mar 15, 2024
chunky/src/java/se/llbit/chunky/ui/controller/ChunkyFxController.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Maik Marschner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requests the user to confirm closing chunky when pressing
Ctrl+Q(or usingFile > Quit).This PR does not yet track saved changes. This confirmation dialog is always shown when quitting at the moment.
Further work is needed to skip this dialog when no unsaved changes have been made as described in #951 (comment).
I suggest that this closes #951 and we open a separate issue for the work on "dirty state" tracking.