Homogenize Depth #1672
Merged
Homogenize Depth #1672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah, stuff like this makes understanding the path tracing in Chunky even harder. Thanks for changing it. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chunky would rely
Ray.set(Ray)to increase the depth, however different routines calls this a different amount of times leading to different ray depths in a scene. Here I have removed that change and made ray depth increase explicitly to successive frames inPathTracer.pathTrace. Currently this does not explicitly change the output, but it could be a easy mistake in the future or if the ray depth is needed in other parts of the code.