Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the available physical memory as upper memory limit for the slider in the launcher. #1433

Merged
merged 2 commits into from
Oct 27, 2023

Conversation

leMaik
Copy link
Member

@leMaik leMaik commented Aug 13, 2022

@leMaik
Copy link
Member Author

leMaik commented Aug 14, 2022

On Discord, it was suggested to change the slider to keep a bit of memory. We could either limit it to some percentage or to X% of free ram at the time of starting. Just to make sure that people don't run OOM by sliding it all the way to the right.

@ShirleyNekoDev
Copy link
Member

On Discord, it was suggested to change the slider to keep a bit of memory. We could either limit it to some percentage or to X% of free ram at the time of starting. Just to make sure that people don't run OOM by sliding it all the way to the right.

I'd assume that this should not be a problem for modern systems - When Java requests all system memory, the OS might assign it as virtual memory and page it out as needed, otherwise the JVM should terminate either way if allocation from system fails.
(This feature is probably mostly relevant for power users, which want to manage their system resources without restrictions.)

@leMaik leMaik merged commit 355f76d into chunky-dev:master Oct 27, 2023
1 check passed
@leMaik leMaik deleted the launcher-upper-memory-limit branch October 27, 2023 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants