[ENH] Update Python SysDB to support get_collection_size #3507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please tag your PR title with one of: [ENH | BUG | DOC | TST | BLD | PERF | TYP | CLN | CHORE]. See https://docs.trychroma.com/contributing#contributing-code-and-ideas |
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
drewkim
changed the title
codetheweb
reviewed
Jan 17, 2025
| @@ -273,6 +273,16 @@ def test_create_get_delete_collections(sysdb: SysDB) -> None: | |||
| assert by_collection_result == [] | |||
|
|
|||
|
|
|||
| def test_get_collection_size(sysdb: SysDB) -> None: | |||
| if not isinstance(sysdb, GrpcSysDB): | |||
| pytest.skip("Skipping because this functionality is only supported by GrpcSysDB") | |||
There was a problem hiding this comment.
why not support it for single node?
There was a problem hiding this comment.
This is strictly to support a distributed use case. Also, they have different schemas so we'd be introducing more change for no gain
drewkim
force-pushed
the
drew/python_sysdb_get_collection_size
branch
from
29faa5a to
08fa8bc
Compare
drewkim
changed the base branch from
drew/_enh_getcollectionsize_on_sysdb_read_replica
to
main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Summarize the changes made by this PR.
get_collection_size()onSysDBTest plan
How are these changes tested?
pytestfor python,yarn testfor js,cargo testfor rustDocumentation Changes
Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?