Do not warn by default if EOL is missing in spc file

[andreranza]

If a spc file without EOL is given, we get a warning.

pkgload::load_all()
#> ℹ Loading seasonal

import.spc("inst/tests/trial.spc") # trial.spc has no EOL
#> Warning in readLines(file): incomplete final line found on
#> 'inst/tests/trial.spc'
#> ## import input series
#> x <- ts(c(112, 118, 132, 129, 121, 135, 148, 148, 136, 119, 104, 
#>     118, 115, 126, 141, 135, 125, 149, 170, 170, 158, 133, 114, 
#>     140, 145, 150, 178, 163, 172, 178, 199, 199, 184, 162, 146, 
#>     166), start = c(1949, 1), frequency = 12)
#> 
#> ## main call to 'seas'
#> seas(x = x, series.print = "brief", automdl = NULL, outlier = NULL, 
#>     regression.aictest = NULL)

^{Created on 2024-06-10 with reprex v2.1.0}

With this PR, we give the choice to user whether to silence it or not. By default, we make it silent.

pkgload::load_all()
#> ℹ Loading seasonal

import.spc("inst/tests/trial.spc") # trial.spc has no EOL
#> ## import input series
#> x <- ts(c(112, 118, 132, 129, 121, 135, 148, 148, 136, 119, 104, 
#>     118, 115, 126, 141, 135, 125, 149, 170, 170, 158, 133, 114, 
#>     140, 145, 150, 178, 163, 172, 178, 199, 199, 184, 162, 146, 
#>     166), start = c(1949, 1), frequency = 12)
#> 
#> ## main call to 'seas'
#> seas(x = x, series.print = "brief", automdl = NULL, outlier = NULL, 
#>     regression.aictest = NULL)

^{Created on 2024-06-10 with reprex v2.1.0}

[christophsax]

Thanks a lot, @andreranza!

Do you see a downside if this is always FALSE? What is the benefit of the warning?

[andreranza]

@christophsax, not at the moment. Probably making it FALSE by default won't harm but since I wasn't sure I let the choice to the user for now. We can of course investigate a bit more.

[christophsax]

Thanks, @andreranza. I have this included in #326, without the user options. Closing this.