Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The default data format for X-13 is "free" #324

Merged
merged 2 commits into from
Jun 14, 2024

Conversation

andreranza
Copy link
Collaborator

Closes #323.

Code
ext_ser_call(pp, "x")
Output
[1] "x <- import.ts(file.dat)"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@christophsax, I am unsure about this generated call. Does it sound reasonable to you? Why not something like x <- import.ts(file.dat, format = \"datevalue\", start = c(2014, 1), frequency = 12, name = \"xyz\")?

@andreranza
Copy link
Collaborator Author

As a result:

pkgload::load_all()
#> ℹ Loading seasonal

text <- '
  series{
  title = "Commercial and industrial machinery and equipment (except automotive and electronic) repair and main"
  start = 2014.01
  period = 12
  save = (A1 B1)
  print = BRIEF
  format = "datevalue"
  name = "8081130000 - HE"
  file = "seasonal/tests/nocran/spc/x11_m1r.dat"
}'


import.spc(text = text)
#> ## import input series
#> x <- import.ts("seasonal/tests/nocran/spc/x11_m1r.dat")
#> 
#> ## main call to 'seas'
#> seas(x = x, series.save = c("a1", "b1"), series.print = "brief", 
#>     automdl = NULL, outlier = NULL, regression.aictest = NULL)

Created on 2024-06-10 with reprex v2.1.0

Copy link
Owner

@christophsax christophsax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@christophsax christophsax merged commit 7a2876c into christophsax:main Jun 14, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unspecified format argument in spc file leads to error
2 participants