Generate sealed class for windows runtime library compatibility

christianhelle · Nov 9, 2017 · 2e0257c · 2e0257c
1 parent 0559618
commit 2e0257c
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 5 deletions.
diff --git a/vs2017/VSPackage.Tests/CSharpCodeGeneratorTests.cs b/vs2017/VSPackage.Tests/CSharpCodeGeneratorTests.cs
@@ -32,7 +32,7 @@ public void GenerateCodeDoesNotReturnNull()
         [TestMethod]
         public void GeneratedCodeIsAPublicClass()
         {
-            Assert.IsTrue(actual.Contains("public partial class"));
+            Assert.IsTrue(actual.Contains("public sealed partial class"));
         }
 
         [TestMethod]

diff --git a/vs2017/VSPackage.Tests/CSharpCodeGeneratorTestsInternal.cs b/vs2017/VSPackage.Tests/CSharpCodeGeneratorTestsInternal.cs
@@ -33,7 +33,7 @@ public void GenerateCodeDoesNotReturnNull()
         [TestMethod]
         public void GeneratedCodeIsAnInternalClass()
         {
-            Assert.IsTrue(actual.Contains("internal partial class"));
+            Assert.IsTrue(actual.Contains("internal sealed partial class"));
         }
 
         [TestMethod]

diff --git a/vs2017/VSPackage.Tests/VisualBasicCodeGeneratorInternalTests.cs b/vs2017/VSPackage.Tests/VisualBasicCodeGeneratorInternalTests.cs
@@ -34,7 +34,7 @@ public void GenerateCodeDoesNotReturnNull()
         [TestMethod]
         public void GeneratedCodeIsFriendClass()
         {
-            Assert.IsTrue(actual.Contains("Partial Friend Class"));
+            Assert.IsTrue(actual.Contains("Partial Friend NotInheritable Class"));
         }
 
         [TestMethod]

diff --git a/vs2017/VSPackage/CustomTool/CodeDomCodeGenerator.cs b/vs2017/VSPackage/CustomTool/CodeDomCodeGenerator.cs
@@ -56,8 +56,9 @@ public override string GenerateCode()
             var targetClass = new CodeTypeDeclaration(className)
             {
                 IsClass = true,
-                IsPartial = true,
-                TypeAttributes = classAccessibility.HasValue ? classAccessibility.Value : TypeAttributes.Public
+                IsPartial = true, 
+                TypeAttributes = TypeAttributes.Sealed | (classAccessibility ?? TypeAttributes.Public),
+                Attributes = MemberAttributes.Public | MemberAttributes.Static | MemberAttributes.Final
             };
 
             const string resourceLoaderType = "ResourceLoader";