Allow configuration of vm bridge #21
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using 4.3G as disk size leads to error message indicating critically low value during package installation.
christensenjairus
requested changes
Jan 12, 2025
| @@ -72,14 +72,16 @@ ETCD_VERSION=3.5.16 | |||
| # template creation process. | |||
|
|
|||
| ### Debian 12 Image (Bookworm) | |||
| TEMPLATE_VM_BRIDGE=vmbr0 | |||
There was a problem hiding this comment.
Could you place this up near line 12?
There was a problem hiding this comment.
Could you also add the TEMPLATE_VM_BRIDGE variable somewhere near line 280 in clustercreator.sh? To ensure that the script does not run if the user did not define it.
|
|
||
| ### Ubuntu 24.04 LTS Image (Noble Numbat) | ||
| #TEMPLATE_VM_BRIDGE=vmbr0 |
There was a problem hiding this comment.
When the other line is moved you can remove this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The naming of the network bridge might differ across proxmox installations because of different naming conventions or because of using multiple networks. Externalizing the bridge name for the setup of the vm template as an environment variable avoids applying changes to the shell script directly.
The storage requirements for the debian system and the packages which are installed during the template creation are exceeding the default of 4.3G, increasing the disk to 4.6G solves it.