-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify readme #1
Comments
The fallback-behavior is only present if |
What if I want to use ag by default and fall back to ack or grep if it's |
That would require something like a linked-list to favor certain services over others, and I would rather not do that. Mainly due to personal opinions of people, I hesitated with having the fallback-behaviour due to the same reason. I just took what I wanted for myself I don't see a good solution to this, sorry.. |
Well in that case I don't see the point in using your plugin and Of course, I do see the point if a user's preferences are the same as your |
The idea with the fallback was to provide a sane default to the user, and I don't see it as a problem if you specify a grep-command of your own - you have decided on that command. Feel free to make a pull-request if you find out a solution to this |
@tremby would it work for you if you could specify your fallback? |
I'm actually okay with your defaults: git, then ag, then ack, then grep. I just remain confused about what the point of being allowed to specify |
@tremby What do you think of doing something like - https://github.com/teoljungberg/vim-grep/tree/configure-callback ? |
I think that's more useful than the current behaviour. |
The readme says that git-grep will be used if present, otherwise ag, otherwise ack, otherwise regular grep.
Then the instructions say to install ag, and set
g:grepprg
to ag.Then to install ack, and set
g:grepprg
to ack. But then why did I set it to ag? Which one should it be set to? Isn't the whole point to use git-grep first, then fall back to each alternative?From looking at the code it seems the only reason to set that variable is if I do not want to the fallback behaviour.
The text was updated successfully, but these errors were encountered: