* Makefile fixes for compiling with proper descriptorpb

* Add is_primary to field to help with generating materializedviews later

Makefile

@@ -14,12 +14,12 @@
 
 BQ_PLUGIN=bin/protoc-gen-bq-schema
 GO_PLUGIN=bin/protoc-gen-go
-PROTOC_GEN_GO_PKG=google.golang.org/protobuf/compiler/protogen
+PROTOC_GEN_GO_PKG=google.golang.org/protobuf/cmd/protoc-gen-go
 GLOG_PKG=github.com/golang/glog
 PROTO_SRC=bq_table.proto bq_field.proto
 PROTO_GENFILES=protos/bq_table.pb.go protos/bq_field.pb.go
 PROTO_PKG=google.golang.org/protobuf/proto
-PKGMAP=Mgoogle/protobuf/descriptor.proto=$(PROTOC_GEN_GO_PKG)/descriptor
+PKGMAP=Mgoogle/protobuf/descriptor.proto=google.golang.org/protobuf/types/descriptorpb
 EXAMPLES_PROTO=examples/foo.proto
 
 install: $(BQ_PLUGIN)

README.md

@@ -16,6 +16,11 @@ go install github.com/chreds/protoc-gen-bq-schema@latest
 
 `protoc` and `protoc-gen-bq-schema` commands must be found in $PATH.
 
+Make sure protoc-gen-go version installed is from google.golang.org/protobuf/cmd/protoc-gen-go@latest 
+(See: https://developers.google.com/protocol-buffers/docs/reference/go-generated)
+
+Do NOT use deprecated github.com/golang/protobuf/protoc-gen-go/plugin
+
 The generated JSON schema files are suffixed with `.schema` and their base names are named
 after their package names and `bq_table_name` options.
 

bq_field.proto

@@ -44,6 +44,9 @@ message BigQueryFieldOptions {
 
   // Optionally add PolicyTag for a field in BigQuery schema.
   string policy_tags = 6;
+
+  // Whether is primary key, doesn't impact table schema but can be looked up later (for example for generating materialized views).
+  bool is_primary = 7;
 }
 
 

pkg/converter/convert.go

@@ -8,7 +8,7 @@ import (
 	"path"
 	"strings"
 
-	protos "github.com/chreds/protoc-gen-bq-schema/protos"
+	"github.com/chreds/protoc-gen-bq-schema/protos"
 	"github.com/golang/glog"
 	"google.golang.org/protobuf/types/pluginpb"
 	"google.golang.org/protobuf/encoding/prototext"