(GH-512) Display exit code for packages

If a package is a warning or an error, display that exit code result next to the package name.
chocolatey · Apr 24, 2016 · 2272358 · 2272358
1 parent 0e9b775
commit 2272358
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/src/chocolatey/infrastructure.app/services/ChocolateyPackageService.cs b/src/chocolatey/infrastructure.app/services/ChocolateyPackageService.cs
@@ -372,7 +372,7 @@ public ConcurrentDictionary<string, PackageResult> install_run(ChocolateyConfigu
                 this.Log().Warn(ChocolateyLoggers.Important, "Warnings:");
                 foreach (var warning in packageInstalls.Where(p => p.Value.Warning).or_empty_list_if_null())
                 {
-                    this.Log().Warn(ChocolateyLoggers.Important, " - {0}".format_with(warning.Value.Name));
+                    this.Log().Warn(ChocolateyLoggers.Important, " - {0}{1}".format_with(warning.Value.Name, warning.Value.ExitCode != 0 ? " (exit code {0})".format_with(warning.Value.ExitCode) : string.Empty));
                 }
             }
 
@@ -381,7 +381,7 @@ public ConcurrentDictionary<string, PackageResult> install_run(ChocolateyConfigu
                 this.Log().Error("Failures:");
                 foreach (var failure in packageInstalls.Where(p => !p.Value.Success).or_empty_list_if_null())
                 {
-                    this.Log().Error(" - {0}".format_with(failure.Value.Name));
+                    this.Log().Error(" - {0}{1}".format_with(failure.Value.Name, failure.Value.ExitCode != 0 ? " (exit code {0})".format_with(failure.Value.ExitCode) : string.Empty));
                 }
             }
 
@@ -574,7 +574,7 @@ public ConcurrentDictionary<string, PackageResult> upgrade_run(ChocolateyConfigu
                 this.Log().Warn(ChocolateyLoggers.Important, "Warnings:");
                 foreach (var warning in packageUpgrades.Where(p => p.Value.Warning).or_empty_list_if_null())
                 {
-                    this.Log().Warn(ChocolateyLoggers.Important, " - {0}".format_with(warning.Value.Name));
+                    this.Log().Warn(ChocolateyLoggers.Important, " - {0}{1}".format_with(warning.Value.Name, warning.Value.ExitCode != 0 ? " (exit code {0})".format_with(warning.Value.ExitCode) : string.Empty));
                 }
             }
 
@@ -583,7 +583,7 @@ public ConcurrentDictionary<string, PackageResult> upgrade_run(ChocolateyConfigu
                 this.Log().Error("Failures:");
                 foreach (var failure in packageUpgrades.Where(p => !p.Value.Success).or_empty_list_if_null())
                 {
-                    this.Log().Error(" - {0}".format_with(failure.Value.Name));
+                    this.Log().Error(" - {0}{1}".format_with(failure.Value.Name, failure.Value.ExitCode != 0 ? " (exit code {0})".format_with(failure.Value.ExitCode) : string.Empty));
                 }
             }
 
@@ -654,7 +654,7 @@ public ConcurrentDictionary<string, PackageResult> uninstall_run(ChocolateyConfi
                 this.Log().Error("Failures");
                 foreach (var failure in packageUninstalls.Where(p => !p.Value.Success).or_empty_list_if_null())
                 {
-                    this.Log().Error(" - {0}".format_with(failure.Value.Name));
+                    this.Log().Error(" - {0}{1}".format_with(failure.Value.Name, failure.Value.ExitCode != 0 ? " (exit code {0})".format_with(failure.Value.ExitCode) : string.Empty));
                 }
             }
 

diff --git a/src/chocolatey/infrastructure/results/PackageResult.cs b/src/chocolatey/infrastructure/results/PackageResult.cs
@@ -41,6 +41,7 @@ public bool Warning
         public string InstallLocation { get; set; }
         public string Source { get; set; }
         public string SourceUri { get; set; }
+        public int ExitCode { get; set; }
 
         public PackageResult(IPackage package, string installLocation, string source = null) : this(package.Id.to_lower(), package.Version.to_string(), installLocation)
         {