Fix isa and mabi argument handling #980
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When no target (and neither custom target) was specified, it defaulted to rv32imc which overrode any isa and mabi supplied as arguments. This prevented setting any custom isa and mabi from the command line. New behavior is to only override these if they aren't set by the user explicitly (values specified with --isa and --mabi options override --target). Signed-off-by: Krzysztof Obłonczek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When no target (and neither custom target) was specified, it defaulted to rv32imc which overrode any isa and mabi supplied as arguments. This prevented setting any custom isa and mabi from the command line. New behavior is to only override these if they aren't set by the user explicitly (values specified with --isa and --mabi options override --target).