Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub Actions which publish to PyPI #48

Merged
merged 20 commits into from
Feb 16, 2021

Conversation

mithro
Copy link
Contributor

@mithro mithro commented Feb 5, 2021

This pull request will add a GitHub Action which builds the fasm packages, including binary wheels for Linux, Mac and Windows and then upload them to PyPI.

@mithro mithro requested a review from litghost February 5, 2021 07:04
@unfurl-links unfurl-links bot mentioned this pull request Feb 5, 2021
Makefile Show resolved Hide resolved
@mithro mithro force-pushed the github-actions branch 3 times, most recently from 65ba0c7 to fae3a17 Compare February 8, 2021 21:44
Signed-off-by: Tim 'mithro' Ansell <[email protected]>
Signed-off-by: Tim 'mithro' Ansell <[email protected]>
Signed-off-by: Tim 'mithro' Ansell <[email protected]>
Signed-off-by: Tim 'mithro' Ansell <[email protected]>
Signed-off-by: Tim 'mithro' Ansell <[email protected]>
Signed-off-by: Tim 'mithro' Ansell <[email protected]>
Otherwise on Windows you get errors like;
```
PermissionError: [WinError 5] Access is denied:
'build\\temp.win-amd64-3.6\\Release\\antlr4_runtime\\src\\antlr4_runtime\\.git\\objects\\pack\\pack-65bd2f6de8e3018d18b83281edd60df81726e772.idx'
```

Signed-off-by: Tim 'mithro' Ansell <[email protected]>
Signed-off-by: Tim 'mithro' Ansell <[email protected]>
Signed-off-by: Tim 'mithro' Ansell <[email protected]>
Signed-off-by: Tim 'mithro' Ansell <[email protected]>
Signed-off-by: Tim 'mithro' Ansell <[email protected]>
Otherwise;
```
D:\a\fasm\fasm\src\ParseFasm.cpp(296,29): error C7555: use of designated initializers requires at least '/std:c++latest' [D:\a\fasm\fasm\build\temp.win-amd64-3.6\Release\parse_fasm_tests.vcxproj]
```

Signed-off-by: Tim 'mithro' Ansell <[email protected]>
Otherwise it fails on MacOS X with;
```
error: unknown warning option '-Wimplicit-fallthrough=0'; did you mean '-Wimplicit-fallthrough'? [-Werror,-Wunknown-warning-option]
```

Signed-off-by: Tim 'mithro' Ansell <[email protected]>
Signed-off-by: Tim 'mithro' Ansell <[email protected]>
@mithro mithro changed the title WIP: Add GitHub Actions which publish to PyPI Add GitHub Actions which publish to PyPI Feb 16, 2021
@mithro mithro marked this pull request as ready for review February 16, 2021 18:16
@mithro
Copy link
Contributor Author

mithro commented Feb 16, 2021

@litghost -- As this pull request seems far enough along that someone else can fix the remaining issues and it seems unlikely I'll have time to do it myself, I think we should merge and move forward. Thus, I have logged github issues about the remaining items.

@mithro mithro requested a review from litghost February 16, 2021 18:21
@litghost litghost merged commit 8fb1946 into chipsalliance:master Feb 16, 2021
@mithro mithro deleted the github-actions branch February 16, 2021 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants