Exchange CDI for CDI handle via DPE::Crypto trait #379
+142
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clundin25
commented
Jan 16, 2025
clundin25
force-pushed
the
cdi-handle-exchange-pr
branch
6 times, most recently
from
cab66ad to
fd8ae95
Compare
clundin25
commented
Jan 22, 2025
Comment on lines
+201
to
+205
| for (stored_cdi, stored_handle) in self.export_cdi_slots.iter() { | ||
| if stored_cdi == cdi { | ||
| return Ok(stored_handle.to_owned()); | ||
| } | ||
| } |
There was a problem hiding this comment.
Is this a valid scenario?
jhand2
reviewed
Jan 22, 2025
crypto/src/lib.rs
Outdated
| /// # Arguments | ||
| /// | ||
| /// * `exported_cdi_handle` - The handle to the CDI. | ||
| fn get_cdi_from_exported_handle( |
There was a problem hiding this comment.
Isn't this internal to Caliptra RT FW since SIGN_WITH_EXPORTED is a Caliptra command? I'm not sure DPE needs to be able to do this lookup.
There was a problem hiding this comment.
That's a fair point, I'll remove this from the trait.
clundin25
force-pushed
the
cdi-handle-exchange-pr
branch
from
fd8ae95 to
bdf97b4
Compare
clundin25
force-pushed
the
cdi-handle-exchange-pr
branch
from
bdf97b4 to
5a633c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.