Add certificate generation code to DeriveContext #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clundin25
commented
Jan 15, 2025
Comment on lines
+293
to
+306
| let mut exported_cdi_handle = [0; MAX_EXPORTED_CDI_SIZE]; | ||
| env.crypto | ||
| .rand_bytes(&mut exported_cdi_handle) | ||
| .map_err(DpeErrorCode::Crypto)?; |
There was a problem hiding this comment.
Once refactored this will happen in the call to create_exported_dpe_cert and return in CreateDpeCertResult
clundin25
force-pushed
the
create-cert-in-derive-context
branch
from
848c7bb to
37d063b
Compare
clundin25
force-pushed
the
create-cert-in-derive-context
branch
from
37d063b to
8b54c17
Compare
clundin25
force-pushed
the
create-cert-in-derive-context
branch
from
fdd83b8 to
d25ecbb
Compare
|
Will follow up in a separate PR with verification tests update. |
jhand2
reviewed
Jan 21, 2025
dpe/src/commands/derive_context.rs
Outdated
|
|
||
| Ok(Response::DeriveContextExportedCdi(DeriveContextExportedCdiResp { | ||
| handle: ContextHandle::new_invalid(), | ||
| parent_handle: dpe.contexts[parent_idx].handle, |
There was a problem hiding this comment.
If export_cdi, then retains_parent must be false. So I think the parent handle should be new_invalid. We should see if we can share the logic from line 374 so it doesn't need to be duploicated.
There was a problem hiding this comment.
Moved the parent invalidation logic further up so it is shared with export-cdi.
clundin25
force-pushed
the
create-cert-in-derive-context
branch
2 times, most recently
from
f69d748 to
47c5068
Compare
clundin25
force-pushed
the
create-cert-in-derive-context
branch
from
47c5068 to
ccb2db2
Compare
jhand2
merged commit 27b8300
into
chipsalliance:feature/gh-issue-caliptra-sw-1807
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will return a self-signed certificate and a CDI for the key handle.