Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tagging from DPE #261

Merged
merged 1 commit into from
Nov 20, 2023
Merged

Conversation

sree-revoori1
Copy link
Contributor

@sree-revoori1 sree-revoori1 commented Nov 17, 2023

This will be added to caliptra-sw runtime in a separate PR - see chipsalliance/caliptra-sw#1089.

Fixes #257

@sree-revoori1 sree-revoori1 requested a review from jhand2 November 17, 2023 15:15
zhalvorsen
zhalvorsen previously approved these changes Nov 17, 2023
@jhand2
Copy link
Collaborator

jhand2 commented Nov 20, 2023

nit: The BadTag error code should be removed from dpe/src/response.rs. Also I think the error code values for the profile-defined errors are out of date from the spec. But we can fix that in a follow-up PR if you want.

@sree-revoori1
Copy link
Contributor Author

Deleted BadTag. I'll align the error codes in a later PR.

@sree-revoori1 sree-revoori1 force-pushed the remove_tag branch 2 times, most recently from d01383c to a171c05 Compare November 20, 2023 17:12
This will be added to caliptra-sw runtime in a separate PR.
@jhand2 jhand2 merged commit b62fe70 into chipsalliance:main Nov 20, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move TCI tagging from DPE to Caliptra RT
3 participants