Group .sdata input sections #590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…crashes when non-existent pin is passed into any function.
…Servo * This is needed for the new Firmata support * Also fixed FubarinoSD analog mapping macro so that the new Firmata would work properly * Also fixed some subtle bugs in SoftPWMServo that were not exposed until Firmata really exercised it a lot.
…more chipKIT boards and SoftPWMServo on all pins for Servo and PWM.
…the master in firmata/arduino repo. Adds full chipKIT support for a number of boards, including WF32 and WiFire.
incremented version in platforms
jasonkajita
changed the title
|
hmm, not sure if I did this pull request correctly. Why are there so many commits? |
|
You may have been working from a slightly older repo or something - the main thing is there is only one changed file with your modifications in it. |
|
hey @chipkitbot, this is ok to test |
|
Did this get straightened out? You might amend the commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Group .sdata input sections into the .sdata output section in hardware/pic32/cores/pic32/chipKIT-application-COMMON.ld
Address #589