-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/cgd 36 #5
Conversation
Someone is attempting to deploy this pull request to the Chingu Dashboard Team on Vercel. To accomplish this, the commit author's email address needs to be associated with a GitHub account. Learn more about how to change the commit author information. |
@timothyrusso is attempting to deploy a commit to the Chingu Dashboard Team on Vercel. To accomplish this, @timothyrusso needs to request access to the Team. Afterwards, an owner of the Team is required to accept their membership request. If you're already a member of the respective Vercel Team, make sure that your Personal Vercel Account is connected to your GitHub account. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the comments I left, this looks good. Just one thing though. Can you add the page for this and put the component in that page itself. As a reminder, the techstack folder should contain an index.ts file (for the barrel exports), a page.tsx file, and then the components folder. The contents of the components folder will be same as what you have currently.
Once this is updated, I'll test it locally before merging :)
@Dan-Y-Ko Done, let me know if this is what you are expecting :) |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Ok, I cloned it locally, it looks good. Just a few more things to change.
You can remove what's in there currently, the import for the counter I had there initially is incorrect so might as well edit it to avoid confusion for the others. Hopefully, I covered everything so we can close this pr lol @Dan-Y-Ko Done! Let me know if I must correct something else :) |
As the theming is finalized now, can you update the colors to follow the theming set in Figma (the theme has been merged into the dev branch). |
@Dan-Y-Ko I've updated the colors, but we are missing the color for the Avatar component: #D9D9D9; |
No, that is not part of the theme. You can see the colors in the figma here: https://www.figma.com/file/OAKUcYBLP3UOaRlnKrcf1G/Chingu-Dashboard?node-id=2743%3A14568&mode=dev The figma may not be 100% updated to reflect the theme colors yet. In this case though, it's fine because the avatar component won't really have a color, it should just be an image (in the final product). |
Everything looks good to me now! |
Description and impacts
Jira related story
CGD-36
Screenshots
How to test it
Add the
<TechStackContainer />
component to the ./chingu-dashboard/src/app/page.tsx