Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/auth architecture pt3 #278

Merged
merged 7 commits into from
Nov 14, 2024
Merged

Conversation

Dan-Y-Ko
Copy link
Contributor

@Dan-Y-Ko Dan-Y-Ko commented Nov 7, 2024

Description

This pr takes care of installing and setting up tanstack query. I connected the login and logout functions with the useMutation hook. The behavior should be the same as before except there will be a spinner in the login button after logging in. I also connected the error callback function too (I think I'm gunna refactor the error handling later though), so you can test that as well.

Issue link

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link

vercel bot commented Nov 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
chingu-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 7, 2024 3:14pm

@Dan-Y-Ko Dan-Y-Ko merged commit c05d22c into v0.2.0 Nov 14, 2024
3 checks passed
@Dan-Y-Ko Dan-Y-Ko deleted the refactor/auth-architecture-pt3 branch November 14, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants