Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/cgd 47 #21

Merged
merged 15 commits into from
Sep 19, 2023
Merged

Feature/cgd 47 #21

merged 15 commits into from
Sep 19, 2023

Conversation

JaneMoroz
Copy link
Contributor

Description and impacts

  • Add the dark & light mode functionality
  • Add the dark & light mode toggle button to navbar

Jira related story

CGD-47

Additional info

I used next-themes.

@vercel
Copy link

vercel bot commented Sep 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
chingu-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 19, 2023 11:59am

@JaneMoroz JaneMoroz requested a review from Dan-Y-Ko September 12, 2023 11:56
Copy link
Contributor

@Dan-Y-Ko Dan-Y-Ko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Can you check your colors in the theme again. It looks like the secondary-content, accent, and accent-content colors aren't correct but also do a check again in case I missed a mistake somewhere else as well.
  2. I think this would be a good time to add some tests. I think for now just a simple unit test is fine. Write a test for the functionality of the theme toggle. Create a test folder in the components folder and put your test file in there with .test.tsx extension. Don't need barrel file for this since we're not going to need to access the test file anywhere else in the project.

@Dan-Y-Ko
Copy link
Contributor

There were some problems with the theming identified, so it needs to be changed. So you can hold off on updating the colors for now. I'll let you know when it's finalized.

@JaneMoroz
Copy link
Contributor Author

2. unit test

I think cypress runs tests that are only in cypress/e2e folder 🤔

@Dan-Y-Ko
Copy link
Contributor

  1. unit test

I think cypress runs tests that are only in cypress/e2e folder 🤔

you can use react testing library for the unit tests and cypress for the e2e tests.

Dan-Y-Ko
Dan-Y-Ko previously approved these changes Sep 18, 2023
Copy link
Contributor

@Dan-Y-Ko Dan-Y-Ko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As previously discussed, the changes to the color of the theming can be handled in a different pr. This one looks good to me.

@Dan-Y-Ko Dan-Y-Ko requested a review from marktlinn September 19, 2023 01:35
@JaneMoroz
Copy link
Contributor Author

I have noticed that the profile image path is wrong, I'll fix it when I get home.

Copy link
Contributor

@marktlinn marktlinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just need to fix the avatar image import which @JaneMoroz has already referenced. After that it's good to merge.

@JaneMoroz
Copy link
Contributor Author

LGTM, just need to fix the avatar image import which @JaneMoroz has already referenced. After that it's good to merge.

Done!

@marktlinn marktlinn merged commit e05615b into dev Sep 19, 2023
2 checks passed
@marktlinn marktlinn deleted the feature/CGD-47 branch September 19, 2023 15:50
Dan-Y-Ko pushed a commit that referenced this pull request Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants