-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/cgd 35 #14
Feature/cgd 35 #14
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
#15 (comment) for issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good to me. I don't know if it's only on my machine, but the image for the banner section looks a little squashed and maybe a little blury.
Could you show me what it looks like? I don't think any of us have been too concerned about how it looks on different screen sizes and I haven't been addressing yet because I would like the side nav finished so we have more to work with regarding how the components are laid out and screen sizes. I'm not sure about the blurry thing though (maybe related)? |
OK, no worries, I wasn't testing it at a small break point, just fullscreen on a laptop, the image just looked like it wasn't very good quality, but I don't think it's a big deal at this stage, as it can always be changed out for a higher quality version later. |
Ok so I added quite a bit to this pr. Summary:
To explain how the barrel exports work:
I also added this explanation to the confluence so other people can see it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Only added banner to ideation page. Other pages should be the same for the most part, however the layout needs to be changed a bit to make it look good with this banner. That will be taken care of in another pr after the side nav is finished.
Removed docker and backend related things.