Add 'exclude' field #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clane9
reviewed
Jun 22, 2024
There was a problem hiding this comment.
Thanks @e-kenneally! Left a few minor comments. Can you also add a test_bids2table_exclude in our tests?
| source = Crawler( | ||
| root=root, | ||
| include=["sub-*"], # find subject dirs | ||
| skip=["sub-*"], # but don't crawl into subject dirs | ||
| skip=["sub-*"] + exclude, # but don't crawl into subject dirs |
There was a problem hiding this comment.
Probably we should also pass exclude to the Crawler's own exclude arg? But this should only matter in the odd case that someone tries to exclude a particular subject directory (which to be fair I'm not sure why anyone would do).
Co-authored-by: Connor Lane <[email protected]>
clane9
reviewed
Jun 22, 2024
Co-authored-by: Connor Lane <[email protected]>
Co-authored-by: Connor Lane <[email protected]>
Co-authored-by: Connor Lane <[email protected]>
This was referenced Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #20
I added exclude flag for the command line which just feeds into the pre-existing 'skip' field at runtime. Tested locally.