Fetch BIDS information from schema #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
effigies
reviewed
Jun 20, 2024
| return entity_schema["name"], Optional[type_], field_ | ||
|
|
||
|
|
||
| BIDSEntities: Any = make_dataclass( |
There was a problem hiding this comment.
Suggested change
| BIDSEntities: Any = make_dataclass( | |
| BIDSEntities: type = make_dataclass( |
There was a problem hiding this comment.
I had it like this, but mypy does not like it at all (results in everything being flagged missing-attr). There is an open issue: python/mypy#6063
Co-authored-by: Chris Markiewicz <[email protected]>
effigies
reviewed
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes bids2table fetch BIDS entity definitions and BIDS datatypes from the official BIDS schema.
This will ensure bids2table is always up-to-date and does not need to be changed when the schema changes.
Custom schema definitions can be injected via
bids2table.entities.set_bids_schema_path(...).See also ohbm/hackathon2024#22
@effigies
Note:run(incorrectly) was an integer before - hence certain changes in the tests.