Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
This PR fixes #15
The problem is that
nfq_get_payload
takes a pointer of pointer in parameters in order to return a pointer of the received packet.The original code uses
&*mut libc::c_void
to describe this. This is not correct as the value of the pointer will be modified bynfq_get_payload
. The correct declaration may be&mut *mut libc::c_void
.This code crashed in release mode due to the optimization made:
nfq_get_payload
, but as it's given as&
, it notes that the pointer value cannot be changed.