Enforce freeing Queue::qh by implementing Drop #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chifflier
requested changes
Mar 30, 2020
|
Regarding reworking the API - the netfilter_queue docs have a few modules marked as deprecated that are used in this crate, it might be good to switch away from them at the same time. |
|
For reference, this email describing the API changes and replacement. It seems nfqueue (and nflog) now directly use and expose |
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's possible to leak the handle by not calling
Queue::close.Queue::openmust have been called before it's valid to call any of its instance functions. It may as well be enforced through opening the handle during construction, and then we can be certain it can be deallocated inDrop.A similar problem exists with
create_queueanddestroy_queue, but I'm trying to think of how to solve it in the right way to allow for multiple open queues and maybe supporting an async stream to read from all of them.