Update/download files through integration #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cscheng
approved these changes
Oct 6, 2023
cscheng
approved these changes
Oct 13, 2023
There was a problem hiding this comment.
Looks good. For now, and the type of use cases that are considered, having these files temporarily in memory should work fine. You might want to monitor this in production and if necessary apply changes to accommodate increased memory usage (for instance tweaking gunicorn config).
| try: | ||
| files_to_send[field_name] = (file_name, self.params["files"][file_name]) | ||
| except KeyError: | ||
| return ( |
There was a problem hiding this comment.
Good to see that incorrect file names are caught here with proper feedback for the user. Additionally, you could choose to validate this when saving the integration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows users to set up manifests with download and upload options. You will first have to download a file before you can upload it to a different endpoint.
Especially helpful for moving files between storage providers.