-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: mermaid diagram #191
base: main
Are you sure you want to change the base?
fix: mermaid diagram #191
Conversation
Honestly, I don't remember why it had been commented out. |
Oh ok so do we prefer to remove the diagram? |
Don't know which are the plans, lately. IMHO the diagrams may be helpful, I would even restore the old ones 🤣 |
@kodaline @nicola-corbellini I also like the diagrams and pictures, the more the better |
so do we want to restore the other diagrams? In case I would use git history to find what is missing |
I propose to reactivate the mermaid plugin in the meantime ;-) |
I have checked old versions of the docs but the only flowchart seems to be the one in the issue #190 |
Let me check |
They are available in this version |
LOL I did not went so much back in time, I expected they were removed around the period the mermaid plugin was deactivated ahah ok I will re-add them, thank you @nicola-corbellini <3 |
Fix: reactivating mermaid plugin so that mermaid diagrams are displayed correctly on docs
@nicola-corbellini @sambarza tagging both of you
I have noticed that the issue #190 is due to the commenting of mermaid plugin for mkdocs, I re-added it and tested it locally, the diagram is displayed correctly.
I have no idea if the mermaid plugin was commented for some important reasons or it was just an oversight that's why I want to check with you before merging.