Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to AtomsBase 0.5 #77

Merged
merged 7 commits into from
Nov 27, 2024
Merged

Update to AtomsBase 0.5 #77

merged 7 commits into from
Nov 27, 2024

Conversation

mfherbst
Copy link
Contributor

Updates the AtomsBase conversion layer to AtomsBase 0.4.

Requires JuliaMolSim/AtomsBase.jl#121 to be merged and AtomsBaseTesting released before tests pass.

src/atomsbase.jl Outdated Show resolved Hide resolved
src/atomsbase.jl Outdated Show resolved Hide resolved
@mfherbst
Copy link
Contributor Author

Thanks for your review @Luthaf. This triggered some internal discussion in AtomsBase aboutChemicalSpecies, so this will stall a while.

@mfherbst mfherbst changed the title Update to AtomsBase 0.4 Update to AtomsBase 0.5 Nov 22, 2024
@mfherbst
Copy link
Contributor Author

@Luthaf ping for a review 😄

Copy link
Member

@Luthaf Luthaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update!

@Luthaf Luthaf merged commit 764a9d3 into chemfiles:master Nov 27, 2024
7 checks passed
@Luthaf
Copy link
Member

Luthaf commented Nov 27, 2024

This is now released in version 0.10.42

@mfherbst
Copy link
Contributor Author

Thanks for the merge !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants