Unit tests for freebsd network plugin; plus fixes #1841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaymzh
force-pushed
the
freebsd-tests
branch
2 times, most recently
from
4e74657 to
96c9a73
Compare
jaymzh
force-pushed
the
freebsd-tests
branch
2 times, most recently
from
b574ef5 to
eb0f6d4
Compare
This adds unittests for the FreeBSD network plugin. It also fixes various issues: * It now running on modern freebsd which has extra columns in netstat output. * It now properly reports encapuslation, MTU, and metric It also includes a test case with `::1` on `lo1` to start building out support for sorting out chef#1838 Signed-off-by: Phil Dibowitz <[email protected]>
|
standard.json Let me know if you want me to test anything again. This is the output of doing |
|
Thanks @ramereth - looks good, but can you also give me |
|
Perfect, thanks! All looks good! |
johnmccrae
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds unittests for the FreeBSD network plugin. It also fixes
various issues:
It also includes a test case with
::1onlo1to start building outsupport for sorting out #1838
Signed-off-by: Phil Dibowitz [email protected]