Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use chef 17 for 3.0 tests, chef 18 for 3.1 tests #221

Merged
merged 35 commits into from
Mar 1, 2024
Merged

Use chef 17 for 3.0 tests, chef 18 for 3.1 tests #221

merged 35 commits into from
Mar 1, 2024

Conversation

tpowell-progress
Copy link
Contributor

@tpowell-progress tpowell-progress commented Aug 15, 2023 •
edited
Loading

Description

Changed match for Windows to use mingw instead of mingw32 in order to match x86-mingw-ucrt

Supersedes #219

Also switched over to cookstyle gem.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

@tpowell-progress
Reopen #219
872cca3 
Signed-off-by: Thomas Powell <[email protected]>
@tpowell-progress tpowell-progress marked this pull request as ready for review February 28, 2024 13:38
@tpowell-progress tpowell-progress requested review from a team as code owners February 28, 2024 13:38
tpowell-progress and others added 25 commits February 28, 2024 08:43
@tpowell-progress
bump GA checkout to @4
0af9de2 
Signed-off-by: Thomas Powell <[email protected]>
@tpowell-progress
Fixed a couple of master references
93aa88a 
Signed-off-by: Thomas Powell <[email protected]>
@tpowell-progress
add chef as a development dependency
4be5ca3 
Signed-off-by: Thomas Powell <[email protected]>
@tpowell-progress
install chef for the CI
16d83e4 
Signed-off-by: Thomas Powell <[email protected]>
@tpowell-progress
Try chef dependency instead
ede7927 
Signed-off-by: Thomas Powell <[email protected]>
@tpowell-progress
turn off the bundler cache?
242f7a7 
Signed-off-by: Thomas Powell <[email protected]>
@tpowell-progress
Push a branch gem requirement for validation of tests
d32928b 
Signed-off-by: Thomas Powell <[email protected]>
@tpowell-progress
Switch on chef version requirement
63f7c47 
Signed-off-by: Thomas Powell <[email protected]>
@tpowell-progress
Add 17-stable ohai
cae814f 
Signed-off-by: Thomas Powell <[email protected]>
@tpowell-progress
tilde wakka
9f1978f 
Signed-off-by: Thomas Powell <[email protected]>
@tpowell-progress
fixed version pinning for default gems on 3.1
f73dbaa 
Signed-off-by: Thomas Powell <[email protected]>
@tpowell-progress
Debugging traces
2b496f6 
Signed-off-by: Thomas Powell <[email protected]>
@tpowell-progress
More debug
e2cdd88 
Signed-off-by: Thomas Powell <[email protected]>
@tpowell-progress
Remove puts
1d72f75 
Signed-off-by: Thomas Powell <[email protected]>
@tpowell-progress
trace updated?
592bc6b 
Signed-off-by: Thomas Powell <[email protected]>
@tpowell-progress
Use cookstyle/chefstyle
2713896 
Signed-off-by: Thomas Powell <[email protected]>
@tpowell-progress
Turn back on bundler cache
74cfe6e 
Signed-off-by: Thomas Powell <[email protected]>
@tpowell-progress
Debug list
ec0b426 
Signed-off-by: Thomas Powell <[email protected]>
@tpowell-progress
limit spec run and do a stack trace
182441d 
Signed-off-by: Thomas Powell <[email protected]>
@tpowell-progress
debug key creation
4b2de58 
Signed-off-by: Thomas Powell <[email protected]>
@tpowell-progress
Add caller traces
98f4efc 
Signed-off-by: Thomas Powell <[email protected]>
@tpowell-progress
trace the multi return
1f5812b 
Signed-off-by: Thomas Powell <[email protected]>
@tpowell-progress
inspect the resource
3dbe552 
Signed-off-by: Thomas Powell <[email protected]>
@tpowell-progress
Inspect new resource
da09ff5 
Signed-off-by: Thomas Powell <[email protected]>
@tpowell-progress
trace caller for new resource
76353f8 
Signed-off-by: Thomas Powell <[email protected]>
tpowell-progress and others added 5 commits March 1, 2024 14:20
@tpowell-progress
trace current resource
ccaa8a4 
Signed-off-by: Thomas Powell <[email protected]>
@tpowell-progress
Fix windows ruby 3.1 matcher
451e583 
Signed-off-by: Thomas Powell <[email protected]>
@tpowell-progress
Remove temp code and fix lint
f27ab87 
Signed-off-by: Thomas Powell <[email protected]>
@tpowell-progress
Reenable full spec run
97fd6fd 
Signed-off-by: Thomas Powell <[email protected]>
@tpowell-progress
Clean up comments
e248841 
Signed-off-by: Thomas Powell <[email protected]>
@tpowell-progress tpowell-progress changed the title Reopen #219 Use chef 17 for 3.0 tests, chef 18 for 3.1 tests Mar 1, 2024
@tpowell-progress tpowell-progress mentioned this pull request Mar 1, 2024
Closed
marcparadise
marcparadise reviewed Mar 1, 2024
View reviewed changes
Gemfile Outdated Show resolved Hide resolved
marcparadise
marcparadise requested changes Mar 1, 2024
View reviewed changes
Copy link
Member

@marcparadise marcparadise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good,but I think we should flip that conditional.

@tpowell-progress
3.0, 3.1, and unbounded
6737009 
Signed-off-by: Thomas Powell <[email protected]>
@tpowell-progress
3.0, 3.1, and unbounded
c2d0693 
Signed-off-by: Thomas Powell <[email protected]>
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Mar 1, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@tpowell-progress tpowell-progress merged commit 7475a2d into main Mar 1, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcparadise marcparadise marcparadise approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tpowell-progress @marcparadise