add checking and error handling for encrypted keys and pass_phrases #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi. Your friendly Curry bot here. Just letting you know that there are commit authors in this Pull Request who appear to not have signed a Chef CLA. The following GitHub users do not appear to have signed a CLA: |
| format = nil | ||
| encrypted = nil | ||
|
|
||
| if key_contents.include?('ENCRYPTED') |
There was a problem hiding this comment.
Is there a more specific way to test for this? The key_contents could contain the phrase ENCRYPTED in the key itself. Maybe make sure it's on the first line?
|
I've fixed the main underlying issue here (thanks TONS for the pointer and the repro): 7abe8bb Please do continue with this for the error message--I like what you are doing. |
|
Hey @cfortier2: given the underlying issue fix, should this be merged or modified? |
|
Closing for now. Reopen if you'd like to do the error message! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this fixes #9
This is my first attempt at fixing this and want to start a discussion to make sure i'm going in the right direction. Any feedback is appreciated!