Constrain minitar gem version and fix require #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should be just specifying `"~> 1.0"`, but backlevel support has been added because Berkshelf still claims to support Ruby 2.7+ and Minitar 1.0 (which is the only supported branch as of 20204-08-07) has explicitly dropped support for any Ruby version 3.0 or older. Minitar v0.12 is the last of the versions for that line and all users are encouraged to upgrade to v1.0 (no one should be running anything older than Ruby 3.1). This is a fairly critical update as users of berkshelf are unable to install or use it without this change. I would strongly recommend that other dependencies like `thor` and `chef` itself where there is an unconstrained `>=` specification be reviewed. This is a potential security or incompatibility hole for all of your users. Resolves: #26 Signed-off-by: Austin Ziegler <[email protected]>
|
3 tasks
|
@halostatue I'm resolving the PR in #30 so that we can get this merged. |
|
Superseded by #30 with berkshelf.gemspec conflict fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be just specifying
"~> 1.0", but backlevel support hasbeen added because Berkshelf still claims to support Ruby 2.7+ and
Minitar 1.0 (which is the only supported branch as of 20204-08-07) has
explicitly dropped support for any Ruby version 3.0 or older.
Minitar v0.12 is the last of the versions for that line and all users
are encouraged to upgrade to v1.0 (no one should be running anything
older than Ruby 3.1).
This is a fairly critical update as users of berkshelf are unable to
install or use it without this change.
I would strongly recommend that other dependencies like
thorandchefitself where there is an unconstrained>=specification bereviewed. This is a potential security or incompatibility hole for all
of your users.
Resolves: #26