Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes for Major Version 5 #8697

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Changes for Major Version 5 #8697

wants to merge 1 commit into from

Conversation

Dmaddu
Copy link
Collaborator

@Dmaddu Dmaddu commented Dec 17, 2024

  • Testing changes

  • Testing changes

  • Adding env in user bin

  • Cleaning the docs correction in integration tests, exclusing system level index

  • fixing pipelines

  • Adding

  • Adding

  • Adding index names in cleanup

  • Adding correct number of indicies


🔩 Description: What code changed, and why?

⛓️ Related Resources

👍 Definition of Done

👟 How to Build and Test the Change

✅ Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

📷 Screenshots, if applicable

Copy link

netlify bot commented Dec 17, 2024

👷 Deploy Preview for chef-automate processing.

Name Link
🔨 Latest commit f783bd4
🔍 Latest deploy log https://app.netlify.com/sites/chef-automate/deploys/6763e4bdcaee5e00082f2d38

* Testing changes

Signed-off-by: Yashvi Jain <[email protected]>

* Testing changes

Signed-off-by: Yashvi Jain <[email protected]>

* Adding env in user bin

Signed-off-by: Yashvi Jain <[email protected]>

* Cleaning the docs correction in integration tests, exclusing system level index

Signed-off-by: Yashvi Jain <[email protected]>

* fixing pipelines

Signed-off-by: Yashvi Jain <[email protected]>

* Adding

Signed-off-by: Yashvi Jain <[email protected]>

* Adding

Signed-off-by: Yashvi Jain <[email protected]>

* Adding index names in cleanup

Signed-off-by: Yashvi Jain <[email protected]>

* Adding correct number of indicies

Signed-off-by: Yashvi Jain <[email protected]>

---------

Signed-off-by: Yashvi Jain <[email protected]>
Co-authored-by: Yashvi Jain <[email protected]>
@YashviJain01 YashviJain01 force-pushed the feature/major_version_5 branch from b066026 to f783bd4 Compare December 19, 2024 09:17

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants