Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add checklist for v5 for postgres #8672

Merged
merged 5 commits into from
Dec 11, 2024

Conversation

Sahiba3108
Copy link
Collaborator

@Sahiba3108 Sahiba3108 commented Dec 5, 2024

πŸ”© Description: What code changed, and why?

⛓️ Related Resources

https://progresssoftware.atlassian.net/browse/CHEF-17285

πŸ‘ Definition of Done

πŸ‘Ÿ How to Build and Test the Change

βœ… Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

πŸ“· Screenshots, if applicable

Embedded PG:
Screenshot 2024-12-11 at 2 05 43β€―PM

External PG:
Screenshot 2024-12-11 at 2 17 06β€―PM

@Sahiba3108 Sahiba3108 self-assigned this Dec 5, 2024
Copy link

netlify bot commented Dec 5, 2024

πŸ‘· Deploy Preview for chef-automate processing.

Name Link
πŸ”¨ Latest commit a05dc82
πŸ” Latest deploy log https://app.netlify.com/sites/chef-automate/deploys/67595326480e86000899729c

Quality Gate failed Quality Gate failed

Failed conditions
7 New issues
4.3% Coverage on New Code (required β‰₯ 80%)
19.7% Duplication on New Code (required ≀ 3%)

See analysis details on SonarQube

Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

@Sahiba3108 Sahiba3108 marked this pull request as ready for review December 11, 2024 09:00
@Sahiba3108 Sahiba3108 requested review from Dmaddu and a team December 11, 2024 09:00
@Dmaddu Dmaddu changed the base branch from main to milestone_release_for_v5 December 11, 2024 15:34
@Dmaddu
Copy link
Collaborator

Dmaddu commented Dec 11, 2024

Hi @Sahiba3108 Video is mandatory for the PRs to merge, since this goes to the feature branch, I am merging this. Plz upload the video next time onwards.

@Dmaddu Dmaddu merged commit 5d3fd0b into milestone_release_for_v5 Dec 11, 2024
9 of 12 checks passed
@Dmaddu Dmaddu deleted the sahiba/v5_checklist_for_postgres branch December 11, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants