-
-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Numberless mode #849
base: main
Are you sure you want to change the base?
Numberless mode #849
Conversation
- replaces all numbers greater than 1 with "Several" - adds a new experimental setting (default `false`) for this behavior A quick audit tells me that `shortenNumber` is consistently used everywhere I would want to change, so I cut out the middleman and did it there.
In my testing, I've spotted a couple places where some metrics are still visible with this option enabled:
|
woo thank you jae. excited for this to merge it literally solves all my problems |
Just a note, faving or unfaving a post currently animates in a "1" before hiding it on your deployment. |
Used this a bit in my fork and seems to be working fine! 🤩 Text doesn't seem to be updated everywhere like it is when Cloak mode is activated though, I wonder what's the reason for that... |
* New translations (Spanish) * New translations (Polish)
* New translations (Polish) * New translations (Italian)
* New translations (Spanish) * New translations (Esperanto) * New translations (Spanish) * New translations (Basque)
2 notes:
|
unbelievably hacky! no question there. the use of "several" is a joke relating back to how we handed numbers on cohost.
this is almost certainly the better way to go. I can look into switching to this
git fail on my part; tried to rebase |
false
) for this behaviorA quick audit tells me that
shortenNumber
is consistently used everywhere I would want to change, so I cut out the middleman and did it there.Genuinely unsure if this is the best way to load a setting within a non-component context. Will gladly change if needed.Nearly immediately after opening this PR I realized the (likely) correct way. Let me know if I'm still off-base.