ssl[:verify]: Add :noop option to turn off only the hostname verification #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kares
reviewed
May 24, 2024
| else | ||
| raise "Invalid value for :verify. Valid values are (:default, :browser, :none)" | ||
| raise "Invalid value for :verify. Valid values are (:default, :browser, :noop, :none)" |
There was a problem hiding this comment.
this is simply confusing, I think the other values were trying to help the user understand.
but now having :noop, :none just adds confusion to the mix, guess we could accept :noop internally but maybe as undocumented or at least not shown here...
There was a problem hiding this comment.
Thanks for reviewing, I agree,:noop is indeed confusing, I ended up using it to keep it similar to the Apache's verifier. Other names that came to my mind are:certificate and :ca. Do you have any suggestion?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an
ssl[:verify]option:noopto turn off only the hostname verification, unlike:noneor:disabledthat overrides thetrust_strategy, this new option still validates the certificate, ignoring only the hostname verification.